Skip to content

feat: add blas/ext/join #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 16 commits into from
Dec 21, 2025
Merged

feat: add blas/ext/join #9009

kgryte merged 16 commits into from
Dec 21, 2025

Conversation

@headlessNode
Copy link
Member

@headlessNode headlessNode commented Dec 12, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#124.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/join

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@headlessNode
feat: add blas/ext/join
25f3c66 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 12, 2025
@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Dec 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/join $\color{red}428/432$
$\color{green}+0.00%$ 		$\color{red}40/42$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{red}428/432$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@headlessNode
refactor: apply suggestions from code review
f24e125 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
headlessNode
headlessNode commented Dec 12, 2025
View reviewed changes
@headlessNode
chore: apply suggestion from code review
a25a3a4 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
fix: lint error
a945261 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 16, 2025
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
@kgryte
bench: use consistent dtype between benchmarks
7df7541 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
fix: increase type specificity
5b6b5c0 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
@kgryte
fix: allow non-"generic" output ndarrays
14fc1ac 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
@kgryte
test: fix return values
7007cf4 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
kgryte
kgryte requested changes Dec 16, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 16, 2025
kgryte
kgryte reviewed Dec 16, 2025
View reviewed changes
@headlessNode
refactor: apply suggestions from code review
ea35c4e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 17, 2025
@headlessNode headlessNode requested a review from kgryte December 17, 2025 14:30
@headlessNode
fix: lint error
fb8208b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 19, 2025
@kgryte
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into pr…
65307cf 
…/headlessNode/9009
@kgryte
chore: refactor and clean-up
cbaa8ea 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte requested changes Dec 19, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headlessNode I ended up doing a fairly heavy refactoring. As discussed offline, join should be a general reduction. There is no need to restrict the operation dimensions to only a single dimension.

Furthermore, I renamed the separator option to sep, which is the convention used elsewhere in this project (e.g., see random/streams/*).

Additionally, as in the original review, we don't need an explicit check for a "generic" dtype. That is handled by the dispatcher. It is not clear why you left those checks in place.

Lastly, I did not update any of the tests. I'll leave that as an exercise for you to do in order to get this PR over the finish line. Reductions such as blas/ext/sum should be useful here, as you need to include the usual tests for various dims configurations.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 19, 2025
@headlessNode
refactor: apply suggestions from code review
d4b30d8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
fix: lint errror
a92b378 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode requested a review from kgryte December 21, 2025 11:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 21, 2025
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Dec 21, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 21, 2025
kgryte
kgryte reviewed Dec 21, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 21, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
d12ed27 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit f8eacb1 into stdlib-js:develop Dec 21, 2025
13 checks passed
@headlessNode headlessNode deleted the j-b branch December 22, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/join

3 participants

@headlessNode @stdlib-bot @kgryte